Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] remove pip2 declaration to reduce pip version confusion #3679

Closed
wants to merge 1 commit into from

Conversation

derekwbrown
Copy link
Contributor

What does this PR do?

removes the pip2 definition dependency, so that we don't have multiple pip installs

@derekwbrown derekwbrown added do-not-merge/hold [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. labels Jun 10, 2019
@derekwbrown derekwbrown requested a review from a team as a code owner June 10, 2019 17:39
@olivielpeau olivielpeau added this to the 6.13.0 milestone Jun 11, 2019
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's instead change

pip = "#{windows_safe_path(python_2_embedded)}\\Scripts\\pip.exe"
python = "#{windows_safe_path(python_2_embedded)}\\python.exe"
to

    python = "#{windows_safe_path(python_2_embedded)}\\python.exe"
    pip = "#{python} -m pip"

@olivielpeau
Copy link
Member

On Windows, is it required (or more generally, what are the reasons) to ship pip with python directly, instead of installing it separately from python?

Asking because installing it separately is what's done on Linux/macOS and makes things more flexible, as it makes it easy to upgrade pip (which is quite frequent) separately from python upgrades (which are less frequent).

@olivielpeau olivielpeau modified the milestones: 6.13.0, 6.14.0 Jul 11, 2019
@derekwbrown
Copy link
Contributor Author

After 6.13, we will repackage python such that it no longer includes pip itself. Then the installed pip will become the correct, only version

@derekwbrown
Copy link
Contributor Author

Superseded by #3924

@derekwbrown derekwbrown deleted the db/win-no-pip2 branch July 26, 2019 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. do-not-merge/hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants