[serverless] Async support #8065
Conversation
pkg/serverless/protocol.go
Outdated
| // and called the /hello route on the agent | ||
| clientLibReady bool | ||
|
|
||
| // datadogLambdaApiUsed tracks whether the layer has called the |
There was a problem hiding this comment.
Looks like the second part of this comment is missing
|
|
||
| // Wait on this WaitGroup in controllers to be sure that the Daemon is ready. | ||
| // (i.e. that the DogStatsD server is properly instantiated) | ||
| ReadyWg *sync.WaitGroup | ||
|
|
||
| InvcWg *sync.WaitGroup |
There was a problem hiding this comment.
I would add a docs comment here
There was a problem hiding this comment.
Also, this is maybe a style thing, but I find code more readable with fewer abbreviations, so I would use invocationWg
pkg/serverless/protocol.go
Outdated
| log.Debug("Switching to flush strategy:", newStrat) | ||
| d.flushStrategy = newStrat | ||
| } | ||
| if !shutdown { |
There was a problem hiding this comment.
Looks like the comment above this might need to be updated (I already changed it in my PR though so this could happen as part of a merge conflict resolution)
pkg/serverless/protocol.go
Outdated
| d.httpServer.Shutdown(ctx) | ||
| } | ||
|
|
||
| // WaitUntilClientReady will wait until the client library |
There was a problem hiding this comment.
Missing second half of comment
| @@ -189,6 +198,42 @@ func (d *Daemon) EnableLogsCollection() (string, chan *logConfig.ChannelMessage, | |||
| return httpAddr, logsChan, nil | |||
| } | |||
|
|
|||
| // StartInvocation tells the daemon the invocation began | |||
There was a problem hiding this comment.
I really like these functions -- very clear and to the point!
| @@ -66,8 +72,19 @@ func (d *Daemon) AutoSelectStrategy() flush.Strategy { | |||
| // flushing at least every 10 seconds (at the start of the invocation) | |||
| // TODO(remy): compute a proper interval instead of hard-coding 10 seconds | |||
There was a problem hiding this comment.
Should we remove this TODO?
| @@ -276,6 +322,7 @@ func (f *Flush) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
There was a problem hiding this comment.
Seems that the doc comment for Flush might be out of date
What does this PR do?
Supports async flushing, reducing latency of functions. Flushing will no longer block the lambda function from completing.
Also, sends 'Extension' logs by default.
Motivation
Reduce latency effect on functions.
Additional Notes
Anything else we should know when reviewing?
Describe how to test your changes
Tested manually, and added some unit tests.