Switch Lambda Extension Logs Endpoint #8175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remeh
requested changes
May 19, 2021
There was a problem hiding this comment.
Since we don't want the Serverless Agent to use something else than the HTTP endpoints, I think that would be a better implementation if we had BuildServerlessHTTPEndpoints() directly called from pkg/logs/logs.go with a if serverless. It would have many benefits:
- can't use TCP endpoints from the Serverless Agent through a configuration change
- no propagation of the
serverlessflag in theconfigpackage - no signature change of the
BuildEndpointsfunction so no changes in the security nor cluster agent (but that's a bonus)
Please not that it means that we would have to sanitize the API key in BuildServerlessHTTPEndpoints as well.
WDYT?
remeh
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Send logs from the Lambda Extension to the Lambda HTTP intake.
Motivation
Use the same endpoint in the Lambda Extension as the Datadog Forwarder.
Describe how to test your changes
Manually tested that logs still reach Datadog.