Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] do not report aws.enhanced.init_duration for non cold start invocations #8213

Merged

Conversation

maxday
Copy link
Contributor

@maxday maxday commented May 21, 2021

What does this PR do?

Do not send aws.enhanced.init_duration metrics for non cold start invocations

Motivation

Average on this metric are biased

Describe how to test your changes

Using extension 57 on us-east-1, you should no be able to see this metrics for non cold starts
noMoreZero

@maxday maxday added this to the Triage milestone May 21, 2021
@maxday maxday requested a review from a team as a code owner May 21, 2021 23:40
@maxday maxday changed the title do not report aws.enhanced.init_duration if 0 [Serverless] do not report aws.enhanced.init_duration for non cold start invocations May 21, 2021
Copy link
Contributor

@nhinsch nhinsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@maxday maxday merged commit 28e5725 into release/lambda-extension-v8 May 24, 2021
@maxday maxday deleted the maxday/init-duration-metrics-fix branch May 24, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants