Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add step to assert a field is not present #1901

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Add step to assert a field is not present #1901

merged 4 commits into from
Mar 11, 2024

Conversation

antonio-ramadas-dd
Copy link
Contributor

What does this PR do?

Add new step to assert on Cucumber that a field is missing. This allows us to be more comprehensive when writing tests.

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.

  • This PR does not rely on API client schema changes.

    • The CI should be fully passing.

  • Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@antonio-ramadas-dd antonio-ramadas-dd requested a review from a team as a code owner March 11, 2024 14:48
@antonio-ramadas-dd
Copy link
Contributor Author

/merge

1 similar comment
@antonio-ramadas-dd
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 11, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Mar 11, 2024

❌ MergeQueue

PR already in the queue with status in_progress

If you need support, contact us on Slack #ci-interfaces with those details!

@dd-devflow
Copy link

dd-devflow bot commented Mar 11, 2024

🚨 MergeQueue

There was an unexpected error while creating the working branch

This could indicate that something doesn't work properly with the build system or that this one has reached its maximum capacity.
You can try to wait a bit and then re-add your pull request to the queue!

Details

child workflow execution error (type: mergequeue_private.MergeQueue_BuildWorkingBranch, workflowID: d9cdc70a-5a01-4d0f-b773-18be062e1dca_33, runID: 752484e9-967d-46e0-9c2b-eee2ab29f88a, initiatedEventID: 33, startedEventID: 34): Child workflow timeout (type: StartToClose)

If you need support, contact us on Slack #ci-interfaces with those details!

@skarimo skarimo merged commit fe7a9a6 into master Mar 11, 2024
15 checks passed
@skarimo skarimo deleted the antonio.ramadas/add-step-definition branch March 11, 2024 19:09
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
@skarimo
Add step to assert a field is not present (#1901)
b2105fb 
* Add step to assert a field is not present

* Fix method naming

* Fix method naming

---------

Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com> fe7a9a6
@antonio-ramadas-dd antonio-ramadas-dd mentioned this pull request Mar 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarimo skarimo skarimo approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antonio-ramadas-dd @skarimo