Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to a global configuration #900

Merged
merged 7 commits into from
Mar 31, 2022
Merged

Migrate to a global configuration #900

merged 7 commits into from
Mar 31, 2022

Conversation

therve
Copy link
Contributor

@therve therve commented Mar 21, 2022 •
edited

This all the configuration into a single, version-less class.

Pros:

  • Can use one client/one config for everything
  • Less duplication

Cons

  • Version knowledge in the global config, for unstable operations and auth settings (including some backward compatibility hack for unstable operations).

@therve therve requested a review from a team as a code owner March 21, 2022 08:06
@therve therve merged commit 2187ea3 into master Mar 31, 2022
@therve therve deleted the therve/unique-generator branch March 31, 2022 08:38
github-actions bot pushed a commit that referenced this pull request Mar 31, 2022
@therve
Migrate to a global configuration (#900)
db971b7 
* Move to a single generator

To have a unique configuration module, move to a single generator for
both specs.

* Migrate tests

* Typo

* Only support v2 auth

* Small tweaks

* Expose objects in init

* Rebase 2187ea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

Assignees

@therve therve

Labels
changelog/Changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@therve @jirikuncar