Add Agent 7 support #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
commented
Oct 21, 2019
| @@ -38,7 +38,7 @@ datadog_{{ check_name }}_yaml_installed: | |||
| - context: | |||
| check_name: {{ check_name }} | |||
|
|
|||
| {%- if latest_agent_version or parsed_version[1] == '6' %} | |||
| {%- if latest_agent_version or parsed_version[1] != '5' %} | |||
There was a problem hiding this comment.
Is this fine, or would it be safer to only explicitly include Agent 6 and 7, like this:
{%- if latest_agent_version or parsed_version[1] == '6' or parsed_version[1] == '7' %}
in case someone tries to install Agent v4 (which is highly unlikely)?
There was a problem hiding this comment.
For chef I did .to_i > 5, because in ruby that's short and it handles nil gracefully (casts to 0). But I wouldn't worry about Agent 4.
albertvaka
approved these changes
Oct 22, 2019
| @@ -38,7 +38,7 @@ datadog_{{ check_name }}_yaml_installed: | |||
| - context: | |||
| check_name: {{ check_name }} | |||
|
|
|||
| {%- if latest_agent_version or parsed_version[1] == '6' %} | |||
| {%- if latest_agent_version or parsed_version[1] != '5' %} | |||
There was a problem hiding this comment.
For chef I did .to_i > 5, because in ruby that's short and it handles nil gracefully (casts to 0). But I wouldn't worry about Agent 4.
Co-Authored-By: Albert Vaca <albert.vaca@datadoghq.com>
olivielpeau
reviewed
Nov 8, 2019
Co-Authored-By: Olivier Vielpeau <olivielpeau@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the formula to support the Agent v7 distribution channels (apt & yum repositories).
latestwill now point to the latest package in the7channel.Updates documentation to include v7.
Motivation
Add support for the upcoming Agent v7.