Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating supported versions of Golang #261

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

carlosroman
Copy link
Contributor

No description provided.

@carlosroman carlosroman force-pushed the carlosroman/go_1_18 branch 2 times, most recently from 11aa8bc to 38c41cc Compare June 21, 2022 10:41
@carlosroman carlosroman changed the title Carlosroman/go 1 18 Enable go 1.12 in CI Jun 21, 2022
@carlosroman carlosroman force-pushed the carlosroman/go_1_18 branch 5 times, most recently from 7241b61 to d86a699 Compare June 28, 2022 10:41
@carlosroman carlosroman changed the title Enable go 1.12 in CI Drop support for Go 1.12 - 1.15 Jun 28, 2022
@carlosroman carlosroman force-pushed the carlosroman/go_1_18 branch 2 times, most recently from 8f49231 to 6c6f94a Compare June 28, 2022 14:37
@carlosroman carlosroman force-pushed the carlosroman/go_1_18 branch 2 times, most recently from 6585a39 to d693173 Compare August 3, 2022 16:15
@carlosroman carlosroman changed the title Drop support for Go 1.12 - 1.15 Updating supported versions of Golang Aug 3, 2022
@carlosroman carlosroman force-pushed the carlosroman/go_1_18 branch 2 times, most recently from 09f56db to 0a8c7c5 Compare August 5, 2022 10:24
@carlosroman carlosroman marked this pull request as ready for review August 5, 2022 10:25
runs-on: [ ubuntu-latest, windows-latest, macos-latest ]
fail-fast: false
go-version:
- 1.13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as 1.12 version is mentioned here it will be nice to add it to the matrix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the reason this hasn't been merged is because the unit tests won't run for 1.12. I'll hopefully have some time to look at this and fix the matrix + update our support plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants