[SLS-2492] Upgrade aws sdk v2

[DylanLovesCoffee]

What does this PR do?

Migrates existing KMS decryption logic to use aws-sdk-go-v2

Motivation

Upgrade/migrate to aws-sdk-go-v2

Testing Guidelines

Manual testing with KMS encrypted keys

Additional Notes

note: the unit test was removed due to difficulty in mocking the new kms Client with the new sdk version, since previously a KMS interface was available in v1. Ideally we'd want to add back the unit test and potentially have an integration test covering this feature too.

Types of changes

• Bug fix
• New feature
• Breaking change
• Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

• This PR's description is comprehensive
• This PR contains breaking changes that are documented in the description
• This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
• This PR impacts documentation, and it has been updated (or a ticket has been logged)
• This PR's changes are covered by the automated tests
• This PR collects user input/sensitive content into Datadog

[codecov-commenter]

Codecov Report

Merging #113 (ba49bca) into main (1cdcde5) will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   83.45%   83.47%   +0.01%     
==========================================
  Files          13       13              
  Lines         846      847       +1     
==========================================
+ Hits          706      707       +1     
  Misses        111      111              
  Partials       29       29              

Impacted Files	Coverage Δ
internal/metrics/kms_decrypter.go	70.00% <88.88%> (+1.03%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[purple4reina]

Looks good as is, but left comments on ideas for improvement.

[purple4reina]

This is kinda a nit pick, but I think we wanna use context.Background(). We can then also use the same context for both of these kms client calls. It won't change any of the functionality, so really this is just a nit, but it would allow us to do cool things like add timeouts in the future.

[purple4reina]

So, I think these tests can still work, and would actually be a bit more simple than they currently are.

I think (haven't tested this) we can mock out the HTTPClient to just send us the response we want to test. Something like this (note I have not tested this at all):

type mockHTTPClient string

func (m mockHTTPClient) Do(*http.Request) (*http.Response, err) {
  return &http.Response{
    StatusCode: 200,
    Body: ioutil.NopCloser(bytes.NewBufferString(m)),
  }
}

func TestWhatever(t *testing.T) {
  client := kms.New(kms.Options{HTTPClient: mockHTTPClient("hello world")})
  result, _ decryptKMS(client, mockEncryptedAPIKeyBase64)
  assert.Equal(t, expectedDecryptedAPIKey, result)
}

[IvanTopolcic]

LGTM!

[IvanTopolcic]

Does AWS not provide the KMSAPI interface anymore?

[DylanLovesCoffee]

Seems like not with v2 😭

[purple4reina]

🎉