Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go + fasthttp + lint #104

Merged
merged 36 commits into from
Apr 18, 2022
Merged

Bump go + fasthttp + lint #104

merged 36 commits into from
Apr 18, 2022

Conversation

maxday
Copy link
Contributor

@maxday maxday commented Apr 11, 2022

What does this PR do?

  • bump fasthttp
  • update linter
  • fix most linting errors (some SA1029: should not use built-in type string as key for value; define your own type to avoid collision are tricky to fix so I'll leave them for now and should be fixed in another PR
  • bump go -> 1.17
  • fix integration tests --dd-api-key is invalid since serverless@3+
  • update snapshot to have a cleaner diff (same method used in -js and -python)

Motivation

ever greening

@maxday maxday requested a review from a team as a code owner April 11, 2022 17:08
@maxday maxday changed the title Bump fasthttp Bump go + fasthttp Apr 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #104 (b761b02) into main (a929bf5) will decrease coverage by 1.04%.
The diff coverage is 47.36%.

❗ Current head b761b02 differs from pull request most recent head 04c9a13. Consider uploading reports for the commit 04c9a13 to get more accurate results

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   85.31%   84.26%   -1.05%     
==========================================
  Files          13       13              
  Lines         783      788       +5     
==========================================
- Hits          668      664       -4     
- Misses         91       98       +7     
- Partials       24       26       +2     
Impacted Files Coverage Δ
internal/wrapper/wrap_handler.go 97.91% <ø> (ø)
internal/metrics/kms_decrypter.go 68.96% <28.57%> (-7.04%) ⬇️
internal/metrics/listener.go 83.06% <50.00%> (-1.37%) ⬇️
internal/trace/context.go 77.09% <50.00%> (-1.53%) ⬇️
ddlambda.go 78.57% <100.00%> (ø)
internal/metrics/batcher.go 100.00% <100.00%> (ø)
internal/metrics/processor.go 97.70% <0.00%> (-2.30%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@maxday maxday changed the title Bump go + fasthttp Bump go + fasthttp + lint Apr 11, 2022
@maxday maxday requested review from DarcyRaynerDD and a team April 11, 2022 23:03
@maxday maxday merged commit 11ed98d into main Apr 18, 2022
@maxday maxday deleted the maxday/bump-fasthttp branch April 18, 2022 14:47
peterdeme pushed a commit to spacelift-io/datadog-lambda-go that referenced this pull request Nov 15, 2023
peterdeme added a commit to spacelift-io/datadog-lambda-go that referenced this pull request Dec 4, 2023
* Create codeql-analysis.yml (DataDog#100)

* Create codeql-analysis.yml

* Update codeql-analysis.yml

* Update run_integration_tests.sh

* Do not show error messages even if neither DD_API_KEY nor DD_KMS_API_KEY is set when Lambda Extension is running (DataDog#102)

* Bump version to 1.4.0

* Bump go + fasthttp + lint (DataDog#104)

* Consolidate serverless configurations into one place (DataDog#105)

* Update README.md

* Update README.md

* Bump dd-trace-go to latest version to address some vulnerabilities (DataDog#109)

* Bump dd-trace-go to latest version to address some vulnaribilities
* update go.sum with `go mod tidy`

* Bump version to 1.6.0

* bump codeql (DataDog#112)

* Bump dd-trace-go to v1.41 (DataDog#115)

* Bump version to 1.7.0

* [SLS-2330] Add support for universal instrumentation with the extension (DataDog#116)

add option to use universal instrumentation

* [EEP-444] include error in failed metric send log (DataDog#118)

Co-authored-by: Corey Griffin <CoreyGriffin@users.noreply.github.com>

* [SLS-2492] Upgrade aws sdk v2 (DataDog#113)

upgrade sdk

* Bump version to 1.8.0

* Use new account in integration tests (DataDog#119)

* set the architecture explicitely (DataDog#122)

* mask init runtime logs (DataDog#123)

* Update libs (DataDog#121)

* bump go 1.18 (DataDog#125)

* Retry sending trace payloads on failure. (DataDog#128)

* Bump version to 1.9.0

* Update DD Trace to  v1.51.0(DataDog#133)

* Bump go version to 1.20 (DataDog#140)

Bump go version to 1.20

* Upgrade version of dd-trace-go to v1.54.1 (DataDog#141)

* Bump version to 1.10.0

* Propagate trace context from SQS events (DataDog#142)

* Default parent id to be trace id if not found elsewhere.

* Look for trace context in context object as well as headers.

* Apply trace context before starting the function execution span.

* Update signature in tests.

* Add spanid of execution span to context.

* Do not ignore priority "-128".

* Test that default parent id set to trace id.

* Test span id added to context.

* Test uses trace context from context object.

* Bump version to 1.11.0

* feat: automate AppSec enablement setup (e.g: `AWS_LAMBDA_RUNTIME_API`) (DataDog#143)

* feat: honor AWS_LAMBDA_EXEC_WRAPPER when AWS Lambda does not

In order to simplify onboarding & make it more uniform across languages,
inspect the value of the `AWS_LAMBDA_EXEC_WRAPPER` environment variable
and apply select environment variable changes it perofrms upon
decorating a handler.

This is necessary/useful because that environment variable is not
honored by custom runtimes (`provided`, `provided.al2`) as well as the
`go1.x` runtime (which is a glorified provided runtime). The datadog
Lambda wrapper starts a proxy to inject ASM functionality directly on
the Lambda runtime API instead of having to manually instrument each and
every lambda handler/application, and modifies `AWS_LAMBDA_RUNTIME_API`
to instruct Lambda language runtime client libraries to go through it
instead of directly interacting with the Lambda control plane.

APPSEC-11534

* pivot to a different, cheaper strategy

* typo fix

* PR feedback

* minor fixups

* add warning in go1.x runtime if lambda.norpc build tag was not enabled

* Bump version to 1.12.0

* Re-add configs after upstream rebase

* Bump packages

* Remove deprecated `io/ioutil` calls

---------

Co-authored-by: Tian Chu <tian.chu@datadoghq.com>
Co-authored-by: Soshi Katsuta <skatsuta@users.noreply.github.com>
Co-authored-by: Maxime David <maxime.david@datadoghq.com>
Co-authored-by: kimi <47579703+kimi-p@users.noreply.github.com>
Co-authored-by: Kimi Wu <kimi.wu@datadoghq.com>
Co-authored-by: Dylan Yang <dylan.yang@datadoghq.com>
Co-authored-by: Corey Griffin <15809365+CoreyGriffin@users.noreply.github.com>
Co-authored-by: Corey Griffin <CoreyGriffin@users.noreply.github.com>
Co-authored-by: Marcin Rabenda <xrn.design@gmail.com>
Co-authored-by: Rey Abolofia <purple4reina@gmail.com>
Co-authored-by: Rey Abolofia <rey.abolofia@datadoghq.com>
Co-authored-by: Andrew Rodriguez <49878080+zARODz11z@users.noreply.github.com>
Co-authored-by: Ivan Topolcic <IvanTopolcic@users.noreply.github.com>
Co-authored-by: Romain Marcadier <romain.muller@telecomnancy.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants