Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #157

Merged
merged 15 commits into from
Feb 2, 2024
Merged

update dependencies #157

merged 15 commits into from
Feb 2, 2024

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Feb 1, 2024

What does this PR do?

Updating dependencies. Ran go get -u ./... ( go get gopkg.in/DataDog/dd-trace-go.v1@v1.60.0 doesn't seem to be enough)

Also fixing the integration tests at the same time. The lambda runtime go1.x is getting deprecated since Jan/8/2024 and will block function update on Mar/12/2024. Then there's an issue with the github action runner ubuntu-latest doesn't have the latest GLIBC so just use CGO_ENABLED=0 to avoid using cgo....

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner February 1, 2024 20:20
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (73ccca7) 81.90% compared to head (7c45571) 81.79%.
Report is 3 commits behind head on main.

❗ Current head 7c45571 differs from pull request most recent head 192f097. Consider uploading reports for the commit 192f097 to get more accurate results

Files Patch % Lines
internal/trace/listener.go 0.00% 4 Missing ⚠️
internal/metrics/listener.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   81.90%   81.79%   -0.11%     
==========================================
  Files          13       13              
  Lines         884      890       +6     
==========================================
+ Hits          724      728       +4     
- Misses        131      132       +1     
- Partials       29       30       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeyzhao2018 joeyzhao2018 merged commit b2ab52f into main Feb 2, 2024
9 checks passed
@joeyzhao2018 joeyzhao2018 deleted the joey/update-dependencies branch February 2, 2024 01:31
@joeyzhao2018 joeyzhao2018 mentioned this pull request Feb 2, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants