Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set error type and stack with universal instrumentation #171

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Set error type and stack with universal instrumentation #171

merged 2 commits into from
Apr 26, 2024

Conversation

purple4reina
Copy link
Contributor

What does this PR do?

From #170 but adds tests.

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@purple4reina purple4reina requested a review from a team as a code owner April 25, 2024 21:19
@purple4reina purple4reina mentioned this pull request Apr 25, 2024
Closed
10 tasks
duncanista
duncanista reviewed Apr 25, 2024
View reviewed changes
internal/extension/extension.go
var builder strings.Builder
pcs := make([]uintptr, opts.StackFrames)

// +3 to exclude runtime.Callers, takeStacktrace and SendEndInvocationRequest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart

duncanista
duncanista approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – get another review please!

TalUsvyatsky
TalUsvyatsky approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@TalUsvyatsky TalUsvyatsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM

@purple4reina purple4reina merged commit 43eac5d into main Apr 26, 2024
9 checks passed
@purple4reina purple4reina deleted the rey.abolofia/error-type-stack branch April 26, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanista duncanista duncanista approved these changes

@dali546 dali546 dali546 left review comments

@TalUsvyatsky TalUsvyatsky TalUsvyatsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@purple4reina @TalUsvyatsky @duncanista @dali546