Fix DatadogMetric generation with operator-sdk 0.17 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vboulineau please let me know if this change doesn't impact to much the functionality inside the cluster-agent. |
clamoriniere
force-pushed
the
clamoriniere/fixMaster
branch
from
67fcfe0
to
36ed596
Compare
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 57.19% 57.19%
=======================================
Files 31 31
Lines 4175 4175
=======================================
Hits 2388 2388
Misses 1606 1606
Partials 181 181
Continue to review full report at Codecov.
|
xornivore
approved these changes
May 26, 2020
the CRD generator doesn't support `float64` as a type of a CRD field. The sugested workaround is to used instead `resource.Quantity`. Related issue: kubernetes-sigs/controller-tools#245 Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
clamoriniere
force-pushed
the
clamoriniere/fixMaster
branch
from
36ed596
to
99076ee
Compare
L3n41c
pushed a commit
that referenced
this pull request
Jun 3, 2020
the CRD generator doesn't support `float64` as a type of a CRD field. The sugested workaround is to used instead `resource.Quantity`, but we choose to use `string` for simplicity Related issue: kubernetes-sigs/controller-tools#245 Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
clamoriniere
added a commit
that referenced
this pull request
Jun 3, 2020
* Fixes #97, Fixes #95, Fixes #101, Fixes #102 * Make the definition of `DD_CRI_SOCKET_PATH` and `DOCKER_HOST` for all containers. * Fix DatadogMetric generation with operator-sdk 0.17 * Add a way to specify environment variables for all containers * Allow to use a custom secret key name when providing API or APP key via an existing secret * This patch adds `$.spec.agent.env` for environment variables that must defined for all the agents and not only the core one. Co-authored-by: Cedric Lamoriniere <cedric.lamoriniere@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The CRD generator doesn't support
float64as a type of a CRD field.The suggested workaround is to used instead
resource.Quantitybut we choose to usestring.Related issue: kubernetes-sigs/controller-tools#245
Motivation
Fix the Master branch, that is broken due to a merge issue.
Additional Notes
Anything else we should know when reviewing?