Miscellaneous fixes #107
Merged
Miscellaneous fixes #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… containers. Fixes #101
the CRD generator doesn't support `float64` as a type of a CRD field. The sugested workaround is to used instead `resource.Quantity`, but we choose to use `string` for simplicity Related issue: kubernetes-sigs/controller-tools#245 Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
`$.spec.agent.config` contains the configuration for core agent. So `$.spec.agent.config.env` applies only to core agent. This patch adds `$.spec.agent.env` for environment variables that must defined for all the agents and not only the core one. Fixes #101
…ia an existing secret Fixes #95
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 57.19% 61.37% +4.17%
==========================================
Files 31 31
Lines 4175 4562 +387
==========================================
+ Hits 2388 2800 +412
+ Misses 1606 1583 -23
+ Partials 181 179 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DD_CRI_SOCKET_PATHandDOCKER_HOSTfor all containers. Fixes Containers in a kind cluster are not being reported in Datadog #101.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?