-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SLO reconcialition loop to avoid creating duplicate SLOs #1177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies
Hey @khewonc @celenechang, Can I have some help merging this PR and adding the required labels? First-time contributor, please let me know if I need to change anything |
@philippeVV thank you very much for your contribution. I happened to be working on this issue as well; would you be willing to test an alternative solution if/when I push my branch? Or perhaps you can share the SLO manifest you used? Thank you. |
@celenechang Yes, I'll be interested to see/test your implementation. In my test, I used the SLO defined in the |
@philippeVV PR opened at #1185. Thank you |
Hey @celenechang, You mentioned on #1185 that you had some reservations regarding the changes in this PR. Can you please elaborate? Thank you |
@philippeVV, first thank you for your contribution and for helping with testing the other PR. Our reservations are mainly around two points:
Sorry, we didn't provide these details earlier. Let me know if you have more questions. |
Thanks for the feedback @levan-m, it's much appreciated. I believe I understand the issues and will try to address them. |
@philippeVV did you have a chance to test the most recent Operator release? |
Hi @levan-m, I didn't get a chance to revisit the issue since then. I'll close the PR until I get time to test it again. |
What does this PR do?
We observed that the SLO controller creates duplicate SLO when running with more than 1 replica. (issue 1062)
The PR fixes the issue by adding a new
SyncStatus
state. The "creating SLO"syncStatus
is used to ensure that only one reconcile loop can be creating an SLO at the time.Motivation
(issue 1062)
Additional Notes
N/A
Minimum Agent Versions
N/A
Describe your test plan
When running the latest version of the operator with more than 1 replica, we observed that a
DatadogSLO
would create 2 SLOs in Datadog. When building the PR, you will observe that only one SLO is created when applying aDatadogSLO
.Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label