Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verify-pr-label-action GH action to allow contributions from fork #159

Merged
merged 1 commit into from Oct 13, 2020

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

See jesusvasquez333/verify-pr-label-action#9 (comment)

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@vboulineau vboulineau added bug Something isn't working component/olm labels Oct 13, 2020
@vboulineau vboulineau requested a review from a team as a code owner October 13, 2020 09:21
@codecov-io
Copy link

Codecov Report

Merging #159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   59.51%   59.51%           
=======================================
  Files          33       33           
  Lines        4456     4456           
=======================================
  Hits         2652     2652           
  Misses       1593     1593           
  Partials      211      211           
Flag Coverage Δ
#unittests 59.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 812a3c4...40ef03f. Read the comment docs.

@@ -1,6 +1,6 @@
name: pull request linter
on:
pull_request:
pull_request_target:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need both pull_request and pull_request_target. because for example this pull request wasn't check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not supposed to be the case, checking.

@vboulineau vboulineau merged commit 7406e05 into master Oct 13, 2020
@vboulineau vboulineau deleted the vboulineau/fix-pr-labels branch October 13, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/olm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants