Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update verify-pr-label-action GH action to allow contributions from fork #159

Merged
merged 1 commit into from Oct 13, 2020
Merged

Update verify-pr-label-action GH action to allow contributions from fork #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/pr-linter.yml
View file
Open in desktop
Expand Up @@ -2,15 +2,17 @@ name: pull request linter
on:
pull_request:
types: [opened, labeled, unlabeled, synchronize]
pull_request_target:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need both pull_request and pull_request_target. because for example this pull request wasn't check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not supposed to be the case, checking.

types: [opened, labeled, unlabeled, synchronize]
jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@v1
- name: Verify Pull Request Labels
uses: jesusvasquez333/verify-pr-label-action@v1.1.0
uses: jesusvasquez333/verify-pr-label-action@v1.3.1
with:
github-token: '${{ secrets.GITHUB_TOKEN }}'
valid-labels: 'bug, enhancement, documentation'

pull-request-number: '${{ github.event.pull_request.number }}'