[v0.7] Backport clusterRoles and clusterRoleBindings fixes #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are deleted (#359) * controllers/datadogagent: don't set dda as owner for cluster roles and bindings DatadogAgent objects are namespace-scoped whereas clusterRoles and clusterRolesBindings are not. This means that DatadogAgent cannot be the owner ref (kubernetes shows warnings in `kubectl get events`). This owner ref is ignored when cascade deleting, so clusterRoles and clusterRolesBindings are never deleted. Also, the owner ref field is never updated even if a new DatadogAgent with the same name is created. * controllers/datadogagent/common_rbac: use labels when deleting ClusterRoles and ClusterRoleBindings * controllers/datadogagent/common_rbac: add helper to get RBAC names for a DDA * controllers/datadogagent/finalizer: delete owned cluster roles and bindings * controllers/datadogagent/controller_test: check ownership labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
clamoriniere
approved these changes
Aug 23, 2021
davidor
deleted the
davidor/0.7-backport-clusteroles-and-bindings-fixes
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merges #358, #359, and #360 in the v0.7 branch.
Notice that the base branch of this PR is
v0.7.