Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in feature override when process or system probe configs are empty #364

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Fix panic in feature override when process or system probe configs are empty

Describe your test plan

Same as #348

@ahmed-mez ahmed-mez added bug Something isn't working component/controller labels Aug 23, 2021
@ahmed-mez ahmed-mez added this to the v0.7 milestone Aug 23, 2021
@ahmed-mez ahmed-mez requested a review from a team as a code owner August 23, 2021 14:08
@ahmed-mez ahmed-mez changed the title attempt fix Fix panic in feature override when process or system probe configs are empty Aug 23, 2021
@davidor
Copy link
Member

davidor commented Aug 23, 2021

@ahmed-mez update your branch so you include #361
That will fix the problem in the validation github action.

@ahmed-mez
Copy link
Contributor Author

thank you @davidor !

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2021

Codecov Report

Merging #364 (ee493dc) into v0.7 (9655bc5) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.7     #364      +/-   ##
==========================================
- Coverage   65.04%   65.01%   -0.04%     
==========================================
  Files          63       63              
  Lines        6901     6905       +4     
==========================================
  Hits         4489     4489              
- Misses       2093     2097       +4     
  Partials      319      319              
Flag Coverage Δ
unittests 65.01% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/datadogagent_default.go 80.63% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9655bc5...ee493dc. Read the comment docs.

@ahmed-mez ahmed-mez merged commit 084c010 into v0.7 Aug 23, 2021
@ahmed-mez ahmed-mez deleted the celene/fix_features_default branch August 23, 2021 14:22
@clamoriniere clamoriniere mentioned this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants