This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
[rubocop] Fix patterns of rubocoped files #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the pattern with the current structure of the integration SDK repos, so that it actually runs on all the rake files. Not super important but nice to have.
Warning: with the updated pattern, rubocop finds
>100offenses on theintegrations-corerepo right now. I can work on fixing them if needed.On a related note, the
.rubocop.ymlfile of this repo is not shipped with the gem and not taken into account in the integration sdk repos. Unsure as to what we should do (if we want to do anything), I'd be fine with having separate rubocop configs for each repo.