This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
Improvements to trace writer and payload queue behaviour. #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJF
commented
Mar 9, 2018
•
AlexJF
commented
- Payload queue could become stuck if queued payloads all expired due to max age before next flush (queue would become of size 0, so we'd never leave the queue state but we'd also never schedule a new retry).
- Clean old (bigger than max age) payloads when inserting new ones not just on flush.
- When we can't serialize a trace or service payload, we should reset our buffers because otherwise we'll probably end up in a serialization error loop and no progress will be made.
- Fixed a flaky test in service writer after logic changes to the buffering mechanism.
* Payload queue could become stuck if queued payloads all expired due to max age before next flush (queue would become of size 0, so we'd never leave the queue state but we'd also never schedule a new retry). * When we can't serialize a trace or service payload, we should reset our buffers because otherwise we'll probably end up in a serialization error loop and no progress will be made. * Fixed a flaky test in service writer after logic changes to the buffering mechanism.
AlexJF
force-pushed
the
alexjf/fix-hanged-queue
branch
from
80a3929
to
7633fd1
Compare
bmermet
approved these changes
Mar 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.