[util] do not read hostname from datadog.conf
#185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to read the `datadog.conf` Datadog Agent configuration file, the user must have read privilege to the file (default to `0640 dd-agent:root`). It is also useless: if a `datadog.conf` file is present on the host, one can use `statsd` to have metrics, events... sent with the appropriate hostname.
|
Thanks @yannmh - let me know when I should upgrade and test this out :) |
|
We took care of this in #428, rather than fully deprecating this agent config hostname look up, it adds an option to turn this on/off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to read the
datadog.confDatadog Agent configuration file,the user must have read privilege to the file (default to
0640 dd-agent:root).It is also useless: if a
datadog.conffile is present on the host, onecan use
statsdto have metrics, events... sent with the appropriatehostname.
Fix #176, #178. Thanks @tgwizard, @donato.