[MA-669] Add support for /v1/downtime/cancel/by_scope.
#488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athap
reviewed
Nov 27, 2019
athap
reviewed
Nov 27, 2019
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
platinummonkey
approved these changes
Dec 10, 2019
nmuesch
requested changes
Dec 10, 2019
|
|
||
| # Create downtime with scope_one | ||
| end = start + 1000 | ||
| downtime_one = dog.Downtime.create(scope=scope_one, start=start, end=end) |
There was a problem hiding this comment.
Thinking about subsequent test runs here. Would creating a downtime that already exists and is disabled just flip the disabled flag back to False?
There was a problem hiding this comment.
Ahh no, it will create a separate downtime with a different downtime["id"].
There was a problem hiding this comment.
Sorry, to clarify: it creates a new one because the start and end will be different depending on the test execution - so you schedule it for a different time period.
There was a problem hiding this comment.
Ahh ok that sounds good to me.
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DataDog/monitor-app
https://docs.datadoghq.com/api/?lang=python#cancel-monitor-downtimes-by-scope