-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MA-669] Add support for /v1/downtime/cancel/by_scope
.
#488
Merged
armcburney
merged 5 commits into
master
from
armcburney/downtime_cancel_by_scope_endpoint
Dec 10, 2019
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
62cb61e
[MA-669] Add support for `/v1/downtime/cancel/by_scope`.
armcburney d86d137
Merge remote-tracking branch 'origin/master' into armcburney/downtime…
armcburney a47c583
Add back the `show_all_parser` for `datadog/dogshell/downtime.py`.
armcburney 521c932
[MA-669] Add tests for the `cancel_downtime_by_scope` functionality.
armcburney 8412a38
[MA-669] Verify downtime is still `disabled=False` if not canceled.
armcburney File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,23 @@ | ||
from datadog.api.resources import GetableAPIResource, CreateableAPIResource,\ | ||
UpdatableAPIResource, ListableAPIResource, DeletableAPIResource | ||
UpdatableAPIResource, ListableAPIResource, DeletableAPIResource, \ | ||
ActionAPIResource | ||
|
||
|
||
class Downtime(GetableAPIResource, CreateableAPIResource, UpdatableAPIResource, | ||
ListableAPIResource, DeletableAPIResource): | ||
ListableAPIResource, DeletableAPIResource, ActionAPIResource): | ||
""" | ||
A wrapper around Monitor Downtiming HTTP API. | ||
""" | ||
_resource_name = 'downtime' | ||
|
||
@classmethod | ||
def cancel_downtime_by_scope(cls, **body): | ||
""" | ||
Cancels all downtimes matching the scope. | ||
|
||
:param scope: scope to cancel downtimes by | ||
:type scope: string | ||
|
||
:returns: Dictionary representing the API's JSON response | ||
""" | ||
return super(Downtime, cls)._trigger_class_action('POST', 'cancel/by_scope', **body) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about subsequent test runs here. Would
creating
a downtime that already exists and is disabled just flip thedisabled
flag back toFalse
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh no, it will create a separate downtime with a different
downtime["id"]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, to clarify: it creates a new one because the
start
andend
will be different depending on the test execution - so you schedule it for a different time period.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh ok that sounds good to me.