Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nginx] No debug logging when doing Pokémon exception handling #1813

Closed
clokep opened this issue Aug 4, 2015 · 1 comment
Closed

[nginx] No debug logging when doing Pokémon exception handling #1813

clokep opened this issue Aug 4, 2015 · 1 comment

Comments

@clokep
Copy link

clokep commented Aug 4, 2015

The nginx code follows a pattern of catching all exceptions when attempting to submit a metric, which makes sense due to wanting to continue without error. Unfortunately, it additionally eats the real error message and displays a super generic message in the logs. This makes it very difficult to actually debug issues.

I ended up manually modifying the code on my local install to figure out that my nginx.yaml had a syntax error in it. It would have been more obvious if the true exception (unhashable type: 'dict') had been printed out. (Additionally, there should probably be error checking when tags are loaded instead of reported.)

I'm willing to fix either or both of these issues, but would like advice on how you would like to see them done (e.g. log at a different level? Log to stderr?). Thanks!

remh added a commit that referenced this issue Sep 14, 2015
@remh
Copy link
Contributor

remh commented Sep 14, 2015

Thanks for the feedback @clokep
Added more logs in #1914

remh added a commit that referenced this issue Oct 23, 2015
urosgruber pushed a commit to urosgruber/dd-agent that referenced this issue Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants