kube_{creator} and kube_service for more metrics #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
force-pushed
the
xvello/docker_k8s_extend_tags
branch
from
d4ae513
to
877e7c7
Compare
xvello
force-pushed
the
xvello/docker_k8s_extend_tags
branch
from
2d613c3
to
8fbd309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kube_service tagging is desactivable as of 5.14.1, see DataDog/integrations-core#476
What does this PR do?
transform kubeutil.get_kube_labels into get_kube_pod_tags to add kube_{creator} and kube_service tags to the dictionnary. This allows docker.* and kubernetes.* metrics to get these tags
Testing Guidelines
Test docker image is dev-dd-agent:xvello_docker_k8s_extend_tags , works on a k8s 1.6.1 cluster, these tags are now consistent between: