[Zookeeper check] bytes_outstanding metric is misleading #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value is not a value in bytes. Fix #1383 We should remove it in a major version of the agent but for now, let’s add a new metric name for this value.
|
Agreed, looks like the CI fails for other reasons. Merging this one. Thanks 👍 |
LeoCavaille
added a commit
that referenced
this pull request
Mar 18, 2015
[Zookeeper check] bytes_outstanding metric is misleading
|
Changes Unknown when pulling f74256d on remh/zk_outstanding into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value is not a value in bytes.
Fix #1383
We should remove it in a major version of the agent but for now, let’s
add a new metric name for this value.