Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating psutil to 3.3.0 #2134

Merged
merged 1 commit into from
Dec 18, 2015
Merged

Updating psutil to 3.3.0 #2134

merged 1 commit into from
Dec 18, 2015

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Dec 8, 2015

No description provided.

@truthbk
Copy link
Member Author

truthbk commented Dec 9, 2015

@talwai
Copy link
Contributor

talwai commented Dec 10, 2015

@truthbk the default configuration for agent_metrics collection will also need an update: https://github.com/DataDog/dd-agent/blob/master/conf.d/agent_metrics.yaml.default

[psutil] Support for deprecated get_memory_info() was dropped in favor of memory_info().

[psutil] support for deprecated get_cpu_time() was dropped in favor of cpu_times().

[psutil] Changing default psutil methods.

[psutil] Gunicorn check should not rely on deprecated get_cpu_times(). Use cpu_times() instead.

[psutil] NUM_CPUS deprecated in favor of cpu_count().

[psutil] agent_metrics.yaml config fixed to use new psutil method names.
@truthbk
Copy link
Member Author

truthbk commented Dec 17, 2015

@talwai thanks for the comment, fixed accordingly. We've now tested both the windows and linux agents with the updated version.

@olivielpeau
Copy link
Member

👍

Let's remember to upgrade psutil on our windows build VMs.

truthbk added a commit that referenced this pull request Dec 18, 2015
@truthbk truthbk merged commit b741ae7 into master Dec 18, 2015
@truthbk truthbk deleted the jaime/psutil_upgrade branch December 18, 2015 16:17
@olivielpeau olivielpeau added this to the 5.7.0 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants