[Network] Implement the check using psutil on Windows #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are too close from the |
| status = self.TCP_STATES['psutil'].get(conn.status) | ||
| metric = self.CX_STATE_GAUGE.get((protocol, status)) | ||
| if metric is None: | ||
| print(protocol, status) |
There was a problem hiding this comment.
Let's remove this print statement
masci
force-pushed
the
massi/network_stats_win
branch
from
825768c
to
8a69267
Compare
|
@masci can you please squash the changes? |
address review comments
masci
force-pushed
the
massi/network_stats_win
branch
from
8a69267
to
25c7ddc
Compare
|
@truthbk done! |
|
Any ETA on this landing? |
|
@gshackles this will be shipped with the upcoming release 5.9, ETA mid September. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
psutil-based check method