[network] Support netstat in Windows #2478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements #2350
|
Tested on windows 2012, looks good to me! @masci Could you squash all the commits into one (and preserve the authorship)? Thanks! |
|
Actually it'd be good to add a comment in |
Apparently there's a typo in the Microsoft documentation enable network check on win cleaner for win users, an instance has to be present to enable the check
masci
force-pushed
the
massi/netstat_on_win
branch
from
b5b946a
to
d4a7629
Compare
|
Discussed with @remh about this addition and he was thinking about implementing this with |
|
Superseded by #2499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original code from #2352
Rebased on master + minor fixes