Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proxysql] A new agent check for ProxySQL #3107

Closed
wants to merge 8 commits into from

Conversation

ovaistariq
Copy link
Contributor

What does this PR do?

This PR introduces a new agent check for ProxySQL which is a high performance MySQL proxy. ProxySQL is officially supported by Percona and is the recommended load balancer for Percona XtraDB Cluster.

Motivation

ProxySQL is a commonly used database proxy in MySQL and Percona XtraDB Cluster deployments, and Datadog is a popular monitoring tool. Datadog currently doesn't have any agent check for ProxySQL, hence adding this agent check to Datadog will benefit other users in the community.

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Additional Notes

Not applicable.

@masci
Copy link
Contributor

masci commented Jan 24, 2017

Hi @ovaistariq and thanks for your code!
We're in the process of moving all the checks to their own repo and this PR will be likely merged here: https://github.com/DataDog/integrations-extras

Feel free to reopen this against the new repo, otherwise we will take care of moving this after releasing 5.12

@masci
Copy link
Contributor

masci commented Jan 30, 2017

Hi @ovaistariq,

Thanks again for your contribution, always very much appreciated. We're currently transitioning our checks to a new SDK-based model for the agent. An unfortunate side-effect is that we have to impose a freeze on the dd-agent repo. The SDK consists of two repositories https://github.com/DataDog/integrations-core and https://github.com/DataDog/integrations-extras, where all of our checks will reside. This PR would belong in the core/extras repository. Would you be so kind as to re-open the PR there? We have facilitated some tools to help you with the SDK development that should help you get up and running in no time: sdk guide datadog sdk gem. We are very sorry for the inconvenience caused.

Thank you for your patience as we make this transition!

@truthbk
Copy link
Member

truthbk commented Jan 31, 2017

@cberry777, @masci and I, we've taken the liberty of opening a PR here to help you transition to the SDK DataDog/integrations-extras#39

We created a patch with your work and dropped it that PR. Please feel free to continue your work there. 🙇

@cberry777
Copy link
Contributor

cberry777 commented Jan 31, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants