Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve status to work even if the sock is missing #97

Merged
merged 4 commits into from
Jul 2, 2012
Merged

improve status to work even if the sock is missing #97

merged 4 commits into from
Jul 2, 2012

Conversation

jkoppe
Copy link

@jkoppe jkoppe commented Jun 29, 2012

if the sock is missing (as it could be from previous versions) but the pid file is present, correctly report status.

@alq666
Copy link
Member

alq666 commented Jun 30, 2012

I think we need some extra logic to test whether dogstatsd is enabled on the box. It comes with dd-agent 3.0.

@jkoppe
Copy link
Author

jkoppe commented Jun 30, 2012

great, we can do that. i'll take a peek at the dogstatsd code soon.

On Sat, Jun 30, 2012 at 1:02 PM, Alexis Lê-Quôc <
reply@reply.github.com

wrote:

I think we need some extra logic to test whether dogstatsd is enabled on the box. It
comes with dd-agent 3.0.


Reply to this email directly or view it on GitHub:
#97 (comment)

Jason Koppe
Jason.Robert.Koppe@gmail.com
Cell (210) 445-8242

@jkoppe
Copy link
Author

jkoppe commented Jul 2, 2012

i added some grep-fu which counts the number of programs in supervisor.conf. all of this feels pretty icky.

@alq666
Copy link
Member

alq666 commented Jul 2, 2012

Thanks. One thing I just did was to revert the sock/rpc definition in the case of debian in the supervisor config 1a8438b because that stuff is already defined in the stock supervisor config. We have a little bit of a split brain (deb uses stock supervisor instance, rpm uses its own instance).

alq666 added a commit that referenced this pull request Jul 2, 2012
…ixes

improve status to work even if the sock is missing (rpm only)
@alq666 alq666 merged commit 146d432 into DataDog:master Jul 2, 2012
yannmh added a commit that referenced this pull request May 13, 2016
**Changes**
* [BUGFIX] Report properly beans with ':' in the name. See [#90][],
* [#91][], [#95][] (Thanks [@Bluestix][])
* [BUGFIX] Sanitize metric names and tags, i.e. remove illegal
* characters. See [#89][]
* [BUGFIX] Support `javax.management.Attribute` attribute types. See
* [#92][] (Thanks [@nwillems][])
* [FEATURE] Add user tags to service checks. See [#96][]
* [FEATURE] Allow group name substitutions in attribute/alias
* parameters. See [#94][], [#97][] (Thanks [@alz][])

<!--- The following link definition list is generated by PimpMyChangelog
--->
[#89]: DataDog/jmxfetch#89
[#90]: DataDog/jmxfetch#90
[#91]: DataDog/jmxfetch#91
[#92]: DataDog/jmxfetch#92
[#94]: DataDog/jmxfetch#94
[#95]: DataDog/jmxfetch#95
[#96]: DataDog/jmxfetch#96
[#97]: DataDog/jmxfetch#97
[@alz]: https://github.com/alz
[@Bluestix]: https://github.com/bluestix
[@nwillems]: https://github.com/nwillems
yannmh added a commit that referenced this pull request May 13, 2016
**Changes**
* [BUGFIX] Report properly beans with ':' in the name. See [#90][],
* [#91][], [#95][] (Thanks [@Bluestix][])
* [BUGFIX] Sanitize metric names and tags, i.e. remove illegal
* characters. See [#89][]
* [BUGFIX] Support `javax.management.Attribute` attribute types. See
* [#92][] (Thanks [@nwillems][])
* [FEATURE] Add user tags to service checks. See [#96][]
* [FEATURE] Allow group name substitutions in attribute/alias
* parameters. See [#94][], [#97][] (Thanks [@alz][])

<!--- The following link definition list is generated by PimpMyChangelog
--->
[#89]: DataDog/jmxfetch#89
[#90]: DataDog/jmxfetch#90
[#91]: DataDog/jmxfetch#91
[#92]: DataDog/jmxfetch#92
[#94]: DataDog/jmxfetch#94
[#95]: DataDog/jmxfetch#95
[#96]: DataDog/jmxfetch#96
[#97]: DataDog/jmxfetch#97
[@alz]: https://github.com/alz
[@Bluestix]: https://github.com/bluestix
[@nwillems]: https://github.com/nwillems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants