Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct handling of javax.management.Attribute #92

Merged
merged 1 commit into from
Apr 27, 2016

Conversation

nwillems
Copy link
Contributor

This is an issue when connecting to OpenDJ from forgerock.

Steps to reproduce:

  • Start OpenDJ and enable JMX
  • Configure as below
  • List matched attributes and see it showing up
  • Collect attributes and see that it is missing(When finally working I had to wait for a second round of collection) - observe "error" in log.
jmx_url: service:jmx:rmi:///jndi/rmi://localhost:1689/org.opends.server.protocols.jmx.client-unknown
user: cn=Directory Manager
password: INSERT YOUR PASSWORD
conf:
    - include:
        domain: org.opends.server
        bean: org.opends.server:Name=rootDSE,Rdn1=cn-monitor,Rdn2=cn-LDAPS_Connection_Handler_0000_port_1636
        attribute:
          ds-connectionhandler-num-connections:
            metric_type: counter
            alias: opendj.num_connections

When investigating I discovered the misconfigured logger in JMXAttribute, that why this is also included.

@yannmh yannmh added this to the 0.11.0 milestone Apr 26, 2016
@yannmh
Copy link
Member

yannmh commented Apr 26, 2016

Thanks a lot for fixing the issue @nwillems, and sorry for the late answer @nwillems.

I added your contribution to our upcoming milestone. We'll review it shortly :)

@olivielpeau olivielpeau self-assigned this Apr 27, 2016
@olivielpeau
Copy link
Member

Looks good, merging!

Thanks again @nwillems!

@olivielpeau olivielpeau merged commit f5904e8 into DataDog:master Apr 27, 2016
yannmh added a commit to DataDog/dd-agent that referenced this pull request May 13, 2016
**Changes**
* [BUGFIX] Report properly beans with ':' in the name. See [#90][],
* [#91][], [#95][] (Thanks [@Bluestix][])
* [BUGFIX] Sanitize metric names and tags, i.e. remove illegal
* characters. See [#89][]
* [BUGFIX] Support `javax.management.Attribute` attribute types. See
* [#92][] (Thanks [@nwillems][])
* [FEATURE] Add user tags to service checks. See [#96][]
* [FEATURE] Allow group name substitutions in attribute/alias
* parameters. See [#94][], [#97][] (Thanks [@alz][])

<!--- The following link definition list is generated by PimpMyChangelog
--->
[#89]: DataDog/jmxfetch#89
[#90]: DataDog/jmxfetch#90
[#91]: DataDog/jmxfetch#91
[#92]: DataDog/jmxfetch#92
[#94]: DataDog/jmxfetch#94
[#95]: DataDog/jmxfetch#95
[#96]: DataDog/jmxfetch#96
[#97]: DataDog/jmxfetch#97
[@alz]: https://github.com/alz
[@Bluestix]: https://github.com/bluestix
[@nwillems]: https://github.com/nwillems
yannmh added a commit to DataDog/dd-agent that referenced this pull request May 13, 2016
**Changes**
* [BUGFIX] Report properly beans with ':' in the name. See [#90][],
* [#91][], [#95][] (Thanks [@Bluestix][])
* [BUGFIX] Sanitize metric names and tags, i.e. remove illegal
* characters. See [#89][]
* [BUGFIX] Support `javax.management.Attribute` attribute types. See
* [#92][] (Thanks [@nwillems][])
* [FEATURE] Add user tags to service checks. See [#96][]
* [FEATURE] Allow group name substitutions in attribute/alias
* parameters. See [#94][], [#97][] (Thanks [@alz][])

<!--- The following link definition list is generated by PimpMyChangelog
--->
[#89]: DataDog/jmxfetch#89
[#90]: DataDog/jmxfetch#90
[#91]: DataDog/jmxfetch#91
[#92]: DataDog/jmxfetch#92
[#94]: DataDog/jmxfetch#94
[#95]: DataDog/jmxfetch#95
[#96]: DataDog/jmxfetch#96
[#97]: DataDog/jmxfetch#97
[@alz]: https://github.com/alz
[@Bluestix]: https://github.com/bluestix
[@nwillems]: https://github.com/nwillems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants