Merge pull request #2017 from DataDog/nogorodnikov/rum-4358/log-messa…

…ge-about-tag-modification-only-once RUM-4358: Log warning about tag modification only once
DataDog · May 2, 2024 · c0eb3d8 · c0eb3d8
2 parents d9e9cad + be760da
commit c0eb3d8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/...droid-core/src/main/kotlin/com/datadog/android/core/constraints/DatadogDataConstraints.kt b/...droid-core/src/main/kotlin/com/datadog/android/core/constraints/DatadogDataConstraints.kt
@@ -35,7 +35,8 @@ class DatadogDataConstraints(private val internalLogger: InternalLogger) : DataC
                 internalLogger.log(
                     InternalLogger.Level.WARN,
                     InternalLogger.Target.USER,
-                    { "tag \"$it\" was modified to \"$tag\" to match our constraints." }
+                    { "tag \"$it\" was modified to \"$tag\" to match our constraints." },
+                    onlyOnce = true
                 )
             }
             tag

diff --git a/...d-core/src/test/kotlin/com/datadog/android/core/constraints/DatadogDataConstraintsTest.kt b/...d-core/src/test/kotlin/com/datadog/android/core/constraints/DatadogDataConstraintsTest.kt
@@ -94,7 +94,8 @@ internal class DatadogDataConstraintsTest {
         mockInternalLogger.verifyLog(
             InternalLogger.Level.WARN,
             InternalLogger.Target.USER,
-            "tag \"$tag\" was modified to \"$expectedCorrectedTag\" to match our constraints."
+            "tag \"$tag\" was modified to \"$expectedCorrectedTag\" to match our constraints.",
+            onlyOnce = true
         )
     }
 
@@ -112,7 +113,8 @@ internal class DatadogDataConstraintsTest {
         mockInternalLogger.verifyLog(
             InternalLogger.Level.WARN,
             InternalLogger.Target.USER,
-            "tag \"$tag\" was modified to \"$expectedCorrectedTag\" to match our constraints."
+            "tag \"$tag\" was modified to \"$expectedCorrectedTag\" to match our constraints.",
+            onlyOnce = true
         )
     }
 
@@ -128,7 +130,8 @@ internal class DatadogDataConstraintsTest {
         mockInternalLogger.verifyLog(
             InternalLogger.Level.WARN,
             InternalLogger.Target.USER,
-            "tag \"$tag\" was modified to \"$expectedCorrectedTag\" to match our constraints."
+            "tag \"$tag\" was modified to \"$expectedCorrectedTag\" to match our constraints.",
+            onlyOnce = true
         )
     }
 
@@ -144,7 +147,8 @@ internal class DatadogDataConstraintsTest {
             InternalLogger.Level.WARN,
             InternalLogger.Target.USER,
             "tag \"$expectedCorrectedTag:\" was modified to " +
-                "\"$expectedCorrectedTag\" to match our constraints."
+                "\"$expectedCorrectedTag\" to match our constraints.",
+            onlyOnce = true
         )
     }