Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sending CPU architecture as part of device info #1000

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

fuzzybinary
Copy link
Contributor

What does this PR do?

Supports sending CPU architecture as part of the Device Info on events.

This utilizes a partial update of the RUM event schema to include 'architecture' but not some other changes in the most up to date schema, essentially putting it in a 'detached HEAD' state.

Architecture is taken from String.getProperty("os.arch") over Build.CPU_ABI both because CPU_ABI is deprecated and because os.arch appears to give us a result closer to what we want, without including the name of the CPU.

Fixes RUMM-2368

Motivation

Dart / Flutter (and, eventually, NDK crashes) will require the CPU architecture to determine which symbol files to utilize to desymbolicate crash reports.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

This utilizes a partial update of the RUM event schema to include 'architecture' but not some other changes in the most up to date schema, essentially putting it in a 'detached HEAD' state.
Architecture is taken from String.getProperty("os.arch") over Build.CPU_ABI both because CPU_ABI is deprecated and because os.arch appears to give us a result closer to what we want, without including the name of the CPU.
@fuzzybinary fuzzybinary requested a review from a team as a code owner July 25, 2022 19:04
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #1000 (f56b1ad) into develop (51c64b7) will increase coverage by 0.03%.
The diff coverage is 94.44%.

@@             Coverage Diff             @@
##           develop    #1000      +/-   ##
===========================================
+ Coverage    83.02%   83.05%   +0.03%     
===========================================
  Files          271      271              
  Lines         9264     9274      +10     
  Branches      1490     1491       +1     
===========================================
+ Hits          7691     7702      +11     
- Misses        1158     1161       +3     
+ Partials       415      411       -4     
Impacted Files Coverage Δ
...core/internal/system/DefaultAndroidInfoProvider.kt 82.61% <0.00%> (-1.84%) ⬇️
...id/core/internal/system/NoOpAndroidInfoProvider.kt 100.00% <100.00%> (ø)
...ndroid/rum/internal/domain/scope/RumActionScope.kt 98.44% <100.00%> (+0.01%) ⬆️
...roid/rum/internal/domain/scope/RumResourceScope.kt 97.91% <100.00%> (+0.02%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 96.90% <100.00%> (+0.03%) ⬆️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 87.57% <100.00%> (+1.70%) ⬆️
...ndroid/core/internal/persistence/file/EventMeta.kt 70.00% <0.00%> (-10.00%) ⬇️
...android/log/internal/logger/TelemetryLogHandler.kt 100.00% <0.00%> (+25.00%) ⬆️

@xgouchet xgouchet added the size-medium This PR is medium sized label Jul 25, 2022
Copy link
Collaborator

@mariusc83 mariusc83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuzzybinary fuzzybinary merged commit f4498a5 into develop Jul 26, 2022
@fuzzybinary fuzzybinary deleted the jward/RUMM-2368-send-device-architecture branch July 26, 2022 11:41
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-medium This PR is medium sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants