Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into SDK v2 branch #1147

Merged
merged 19 commits into from
Nov 21, 2022

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Nov 17, 2022

What does this PR do?

This PR does the merge of develop branch into feature/sdkv2 branch with all the conflicts resolved.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

fuzzybinary and others added 19 commits November 9, 2022 15:50
The device architecture is needed for Flutter symbolication of logs
Updates some default attributes of RUM events in order to standardize and unify behaviour across all sdk platforms.
This will allow cross platform SDKs to modify the configuration before sending it to telemetry.
This is needed for Flutter and React Native to pass their stack traces to the SDK for serialization.
…rum-event-defaults

RUMM-2625 Update default values for RUM events
…guration-mapper

Add telemetry configuration mapper
Add a logger method to log error information from strings
@xgouchet xgouchet added the size-huge This PR is huge sized label Nov 17, 2022
@0xnm 0xnm marked this pull request as ready for review November 17, 2022 14:45
@0xnm 0xnm requested review from a team as code owners November 17, 2022 14:45
@codecov-commenter
Copy link

Codecov Report

Merging #1147 (181c96b) into feature/sdkv2 (07c6fe9) will decrease coverage by 0.04%.
The diff coverage is 82.29%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1147      +/-   ##
=================================================
- Coverage          82.38%   82.34%   -0.04%     
=================================================
  Files                350      351       +1     
  Lines              11559    11748     +189     
  Branches            1980     2003      +23     
=================================================
+ Hits                9522     9673     +151     
- Misses              1423     1454      +31     
- Partials             614      621       +7     
Impacted Files Coverage Δ
...droid/log/internal/logger/ConditionalLogHandler.kt 33.33% <0.00%> (-66.67%) ⬇️
...og/android/log/internal/logger/LogcatLogHandler.kt 64.15% <0.00%> (-13.12%) ⬇️
.../main/kotlin/com/datadog/android/rum/RumMonitor.kt 77.08% <ø> (ø)
...atadog/android/log/internal/domain/LogGenerator.kt 60.00% <40.00%> (-20.00%) ⬇️
...datadog/android/core/internal/utils/UserInfoExt.kt 50.00% <50.00%> (ø)
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 87.19% <63.64%> (-0.12%) ⬇️
...android/log/internal/logger/TelemetryLogHandler.kt 85.71% <66.67%> (+10.71%) ⬆️
.../datadog/android/log/internal/logger/LogHandler.kt 77.78% <75.00%> (-2.22%) ⬇️
...roid/rum/internal/domain/scope/RumResourceScope.kt 95.24% <78.95%> (-1.79%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 95.24% <83.67%> (-1.14%) ⬇️
... and 23 more

@0xnm 0xnm merged commit dd58c5f into feature/sdkv2 Nov 21, 2022
@0xnm 0xnm deleted the nogorodnikov/merge_develop_into_sdkv2_171122 branch November 21, 2022 10:10
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-huge This PR is huge sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants