Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Mobile Vitals image, update text and links #1334

Closed

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Mar 11, 2023

What does this PR do?

Updates the Mobile Vitals screenshot and text to match the new UI.

Motivation

DOCS-4882

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@rtrieu rtrieu requested review from a team as code owners March 11, 2023 01:20
@rtrieu rtrieu changed the title replace image, update text and links Replace Mobile Vitals image, update text and links Mar 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2023

Codecov Report

Merging #1334 (adf9c04) into develop (a2488e4) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1334      +/-   ##
===========================================
- Coverage    81.90%   81.86%   -0.04%     
===========================================
  Files          362      362              
  Lines        12903    12903              
  Branches      2164     2164              
===========================================
- Hits         10568    10563       -5     
- Misses        1679     1683       +4     
- Partials       656      657       +1     

see 11 files with indirect coverage changes

Copy link
Contributor

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but it seems new image is missing in this PR.

@rtrieu
Copy link
Contributor Author

rtrieu commented Mar 13, 2023

@0xnm Thanks for noticing that, Nikita. Due to the way our single-sourcing works, screenshots are in a different repo/PR: DataDog/documentation#17276

@0xnm
Copy link
Contributor

0xnm commented Apr 18, 2023

Hello @rtrieu ! It seems that this PR is stale, is it still valid?

@xgouchet
Copy link
Collaborator

I think this can be discarded as we're planning to remove the docs from the repo anyway

@rtrieu
Copy link
Contributor Author

rtrieu commented Apr 18, 2023

Hi @0xnm @xgouchet yes this branch is stale, and we're moving over to the docs repo anyway, so I will close it out. Thanks!

@rtrieu rtrieu closed this Apr 18, 2023
@xgouchet xgouchet deleted the rtrieu/docs-4882-mobile-vitals-overview-update branch April 19, 2023 06:58
@xgouchet xgouchet added this to the Dropped milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants