Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-1172 AFExtension included in make bump #467

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

buranmert
Copy link
Contributor

What and why?

make bump wasn't bumping DatadogSDKAlamofireExtension.podspec and in case the dev forgets to bump manually that leads to CI failure in release PRs.

How?

Other podspec examples are followed (ie: PodName.podspec.src template) and this extension is included in make bump step.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@buranmert buranmert self-assigned this Apr 13, 2021
@buranmert buranmert requested a review from a team as a code owner April 13, 2021 08:12
Copy link
Collaborator

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@buranmert buranmert force-pushed the buranmert/RUMM-1172-make-bump-alamofire branch from f21aa6d to dc609ea Compare April 13, 2021 10:20
@buranmert buranmert merged commit ddb4dbd into master Apr 13, 2021
@buranmert buranmert deleted the buranmert/RUMM-1172-make-bump-alamofire branch April 13, 2021 10:54
ncreated pushed a commit that referenced this pull request Apr 13, 2021
…amofire

RUMM-1172 AFExtension included in make bump

(cherry picked from commit ddb4dbd)
ncreated pushed a commit that referenced this pull request Apr 13, 2021
…amofire

RUMM-1172 AFExtension included in make bump

(cherry picked from commit ddb4dbd)
@ncreated ncreated mentioned this pull request Apr 13, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants