Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for RN 0.71 #344

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Add Support for RN 0.71 #344

merged 1 commit into from
Dec 28, 2022

Conversation

louiszawadzki
Copy link
Contributor

@louiszawadzki louiszawadzki commented Nov 18, 2022 •
edited
Loading

What does this PR do?

Reflect changes from RN 0.71 in the sourcemaps upload gradle task.

Motivation

Add support for RN 0.71

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

mariusc83
mariusc83 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@mariusc83 mariusc83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louiszawadzki louiszawadzki force-pushed the louiszawadzki/rumm-2730/support-rn-71 branch from 3bdd27e to 451374e Compare December 21, 2022 11:01
@louiszawadzki louiszawadzki force-pushed the louiszawadzki/rumm-2730/support-rn-71 branch from 451374e to 228ec85 Compare December 27, 2022 13:44
@louiszawadzki louiszawadzki marked this pull request as ready for review December 28, 2022 10:06
@louiszawadzki louiszawadzki requested a review from a team as a code owner December 28, 2022 10:06
@louiszawadzki louiszawadzki merged commit e553382 into develop Dec 28, 2022
@louiszawadzki louiszawadzki deleted the louiszawadzki/rumm-2730/support-rn-71 branch December 28, 2022 13:14
@louiszawadzki louiszawadzki mentioned this pull request Jan 12, 2023
Merged
@euc-callum euc-callum mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xnm 0xnm 0xnm approved these changes

@mariusc83 mariusc83 mariusc83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louiszawadzki @mariusc83 @0xnm