[Version Bump] 2.5.1 #2598
Merged
[Version Bump] 2.5.1 #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Code Coverage Report 📊✔️ Merging #2598 into master will not change line coverage
View the full report for further details: Datadog.Trace Breakdown ✔️
The following classes have significant coverage changes.
View the full reports for further details: |
Benchmarks Report 🐌Benchmarks for #2598 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.182 | 1,226.56 | 1,037.29 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net472 | 892ns | 4.4ns | 18.2ns | 0.0719 | 0 | 0 | 457 B |
| master | StartFinishSpan |
netcoreapp3.1 | 886ns | 3.29ns | 12.7ns | 0.00635 | 0 | 0 | 456 B |
| master | StartFinishScope |
net472 | 1.11μs | 3.53ns | 13.7ns | 0.0844 | 0 | 0 | 538 B |
| master | StartFinishScope |
netcoreapp3.1 | 1.23μs | 4.95ns | 23.2ns | 0.00749 | 0 | 0 | 576 B |
| #2598 | StartFinishSpan |
net472 | 906ns | 5ns | 30.4ns | 0.0717 | 0 | 0 | 457 B |
| #2598 | StartFinishSpan |
netcoreapp3.1 | 868ns | 4.67ns | 26ns | 0.00632 | 0 | 0 | 456 B |
| #2598 | StartFinishScope |
net472 | 1.11μs | 4.6ns | 23.5ns | 0.0844 | 0 | 0 | 538 B |
| #2598 | StartFinishScope |
netcoreapp3.1 | 1.06μs | 6.72ns | 62.7ns | 0.00772 | 0 | 0 | 576 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net472 | 1.28μs | 5.94ns | 29.7ns | 0.0839 | 0 | 0 | 538 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 1.13μs | 3.71ns | 14.4ns | 0.00768 | 0 | 0 | 576 B |
| #2598 | RunOnMethodBegin |
net472 | 1.29μs | 5.13ns | 18.5ns | 0.0844 | 0 | 0 | 538 B |
| #2598 | RunOnMethodBegin |
netcoreapp3.1 | 1.16μs | 4.54ns | 23.1ns | 0.00799 | 0 | 0 | 576 B |
zacharycmontoya
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following files were found to be modified. Confirm that these changes were expected (for example, changes to files in the MSI project are expected if our dependencies have changed).
The following files were found to be modified (as expected)
@DataDog/apm-dotnet