Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI does not use consistent paths for $(SolutionDir) #332

Merged
merged 2 commits into from
Apr 26, 2019
Merged

CI does not use consistent paths for $(SolutionDir) #332

merged 2 commits into from
Apr 26, 2019

Conversation

colin-higgins
Copy link
Member

No description provided.

@colin-higgins colin-higgins added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 25, 2019
@colin-higgins colin-higgins added this to the 1.2.0 milestone Apr 25, 2019
@colin-higgins colin-higgins requested a review from a team as a code owner April 25, 2019 21:48
@colin-higgins colin-higgins self-assigned this Apr 25, 2019
brettlangdon
brettlangdon reviewed Apr 25, 2019
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need this command to run in CI?

@colin-higgins
Copy link
Member Author

The if statement is to make sure CI runs regardless of this command or not.
This is only important when debugging samples locally through something like iisexpress.exe because an external compiler process ends up locking onto the dll from our profiler project, preventing subsequent builds.

@colin-higgins colin-higgins merged commit 1a2cd1a into develop Apr 26, 2019
@colin-higgins colin-higgins deleted the colin/make-prebuild-safe-for-ci branch April 26, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees

@colin-higgins colin-higgins

Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-higgins @brettlangdon