Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore HttpException with 404 status code in ASP.NET #719

Merged
merged 1 commit into from
May 15, 2020
Merged

Ignore HttpException with 404 status code in ASP.NET #719

merged 1 commit into from
May 15, 2020

Conversation

kendallb
Copy link
Contributor

@kendallb kendallb commented May 5, 2020 •
edited by lucaspimentel
Loading

Don't set Span.Error in ASP.NET if the raised exception an HttpException with status code 404. See #718.

@kendallb kendallb requested a review from a team as a code owner May 5, 2020 02:09
@colin-higgins
Copy link
Member

Thanks for the contribution @kendallb
We'll review and test this.

@kendallb
Copy link
Contributor Author

kendallb commented May 5, 2020

I could not fully build and test as I don't have VS2019 installed. Looks like it might need some #ifdef's for .net core?

@lucaspimentel lucaspimentel changed the title Ignore 404 exceptions Ignore 404 exceptions in ASP.NET May 11, 2020
lucaspimentel
lucaspimentel approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@lucaspimentel lucaspimentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kendallb
Copy link
Contributor Author

Just curious when this might make into the official release?

@lucaspimentel lucaspimentel merged commit 4fb4e40 into DataDog:master May 15, 2020
@lucaspimentel
Copy link
Member

@kendallb: This change will be included in our next release, which we plan on doing today or Monday. Thanks again!

@lucaspimentel lucaspimentel linked an issue May 15, 2020 that may be closed by this pull request
ASP.NET integration captures HttpException with 404 status code #718
Closed
@lucaspimentel lucaspimentel changed the title Ignore 404 exceptions in ASP.NET Ignore HttpException with 404 status code in ASP.NET May 15, 2020
@lucaspimentel lucaspimentel added this to the 1.17.0 milestone May 15, 2020
@lucaspimentel lucaspimentel added type:bug and removed type:enhancement Improvement to an existing feature labels May 15, 2020
@lucaspimentel lucaspimentel added area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) and removed area:integrations/aspnet labels Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

Assignees
No one assigned
Labels
area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) community type:bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

ASP.NET integration captures HttpException with 404 status code
3 participants
@kendallb @colin-higgins @lucaspimentel