change default operation name

DataDog · Aug 5, 2022 · 2ddbecd · 2ddbecd
1 parent 8d90c9b
commit 2ddbecd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/contrib/99designs/gqlgen/tracer.go b/contrib/99designs/gqlgen/tracer.go
@@ -29,7 +29,7 @@ import (
 )
 
 const (
-	graphQLQuery = "graphql.query"
+	defaultGraphqlOperation = "graphql.request"
 
 	readOp       = "graphql.read"
 	parsingOp    = "graphql.parse"
@@ -71,7 +71,7 @@ func (t *gqlTracer) InterceptResponse(ctx context.Context, next graphql.Response
 	var (
 		octx *graphql.OperationContext
 	)
-	name := graphQLQuery
+	name := defaultGraphqlOperation
 	if graphql.HasOperationContext(ctx) {
 		// Variables in the operation will be left out of the tags
 		// until obfuscation is implemented in the agent.

diff --git a/contrib/99designs/gqlgen/tracer_test.go b/contrib/99designs/gqlgen/tracer_test.go
@@ -26,7 +26,7 @@ func TestOptions(t *testing.T) {
 	}{
 		"default": {
 			test: func(assert *assert.Assertions, root mocktracer.Span) {
-				assert.Equal(graphQLQuery, root.OperationName())
+				assert.Equal("graphql.query", root.OperationName())
 				assert.Equal(query, root.Tag(ext.ResourceName))
 				assert.Equal(defaultServiceName, root.Tag(ext.ServiceName))
 				assert.Equal(ext.SpanTypeGraphQL, root.Tag(ext.SpanType))
@@ -145,7 +145,7 @@ func TestChildSpans(t *testing.T) {
 		opNames = append(opNames, span.OperationName())
 	}
 	assert.ElementsMatch(resNames, []string{readOp, validationOp, parsingOp, query})
-	assert.ElementsMatch(opNames, []string{readOp, validationOp, parsingOp, graphQLQuery})
+	assert.ElementsMatch(opNames, []string{readOp, validationOp, parsingOp, "graphql.query"})
 	assert.NotNil(root)
 	assert.Nil(root.Tag(ext.Error))
 }