Apply suggestions from code review

Co-authored-by: Julio Guerra <julio@datadog.com>
DataDog · Apr 7, 2022 · 5cfd271 · 5cfd271
1 parent f7ee85c
commit 5cfd271
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/internal/appsec/waf.go b/internal/appsec/waf.go
@@ -147,6 +147,7 @@ func newHTTPWAFEventListener(handle *waf.Handle, addresses []string, timeout tim
 			op.AddTag("_dd.appsec.waf.timeouts", float64(wafCtx.TotalTimeouts()))
 			// time.Duration.Microseconds() is only as of go1.13, so we do it manually here
 			addWAFDurationTags(&op.TagsHolder, float64(wafCtx.TotalRuntime()), float64(overallWAFRunDuration.Nanoseconds()))
+			// Log the following metrics once per instantiation of a WAF handle 
 			once.Do(func() {
 				addRulesetInfoTags(&op.TagsHolder, handle.RulesetInfo())
 				op.AddTag(ext.ManualKeep, samplernames.AppSec)
@@ -232,6 +233,7 @@ func newGRPCWAFEventListener(handle *waf.Handle, _ []string, timeout time.Durati
 		op.On(grpcsec.OnHandlerOperationFinish(func(op *grpcsec.HandlerOperation, _ grpcsec.HandlerOperationRes) {
 			op.AddTag("_dd.appsec.waf.timeouts", float64(wafTimeouts))
 			addWAFDurationTags(&op.TagsHolder, float64(wafRunDuration), float64(wafBindingsRunDuration))
+			// Log the following metrics once per instantiation of a WAF handle 
 			metricsOnce.Do(func() {
 				addRulesetInfoTags(&op.TagsHolder, handle.RulesetInfo())
 				op.AddTag(ext.ManualKeep, samplernames.AppSec)