Skip to content

Commit

Permalink
test2
Browse files Browse the repository at this point in the history
  • Loading branch information
knusbaum committed Nov 17, 2022
1 parent 880a9be commit 6a3d6b7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
1 change: 0 additions & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ variables:

trigger_benchmarking_platform:
stage: benchmarks
when: manual
trigger:
project: DataDog/apm-reliability/relenv-microbenchmarking-platform
branch: $DOWNSTREAM_BENCHMARKING_PLATFORM_BRANCH
Expand Down
7 changes: 4 additions & 3 deletions ddtrace/tracer/tracer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1699,7 +1699,7 @@ func TestEnvironment(t *testing.T) {
// BenchmarkConcurrentTracing tests the performance of spawning a lot of
// goroutines where each one creates a trace with a parent and a child.
func BenchmarkConcurrentTracing(b *testing.B) {
tracer, _, _, stop := startTestTracer(b, WithSampler(NewRateSampler(0)))
tracer, _, _, stop := startTestTracer(b, WithLogger(log.DiscardLogger{}), WithSampler(NewRateSampler(0)))
defer stop()

b.ResetTimer()
Expand All @@ -1718,7 +1718,7 @@ func BenchmarkConcurrentTracing(b *testing.B) {
// BenchmarkTracerAddSpans tests the performance of creating and finishing a root
// span. It should include the encoding overhead.
func BenchmarkTracerAddSpans(b *testing.B) {
tracer, _, _, stop := startTestTracer(b, WithSampler(NewRateSampler(0)))
tracer, _, _, stop := startTestTracer(b, WithLogger(log.DiscardLogger{}), WithSampler(NewRateSampler(0)))
defer stop()

for n := 0; n < b.N; n++ {
Expand All @@ -1728,8 +1728,9 @@ func BenchmarkTracerAddSpans(b *testing.B) {
}

func BenchmarkStartSpan(b *testing.B) {
tracer, _, _, stop := startTestTracer(b, WithSampler(NewRateSampler(0)))
tracer, _, _, stop := startTestTracer(b, WithLogger(log.DiscardLogger{}), WithSampler(NewRateSampler(0)))
defer stop()

root := tracer.StartSpan("pylons.request", ServiceName("pylons"), ResourceName("/"))
ctx := ContextWithSpan(context.TODO(), root)

Expand Down

0 comments on commit 6a3d6b7

Please sign in to comment.