ddtrace/mocktracer: use lock in String method (#2229)

ddtrace/mocktracer: use lock in String method Co-authored-by: iharzhavarankau <izhavarankau@fubo.tv>
DataDog · Sep 25, 2023 · 6a938b3 · 6a938b3
1 parent 992bbaf
commit 6a938b3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/ddtrace/mocktracer/mockspan.go b/ddtrace/mocktracer/mockspan.go
@@ -217,6 +217,8 @@ func (s *mockspan) Finish(opts ...ddtrace.FinishOption) {
 
 // String implements fmt.Stringer.
 func (s *mockspan) String() string {
+	s.RLock()
+	defer s.RUnlock()
 	sc := s.context
 	return fmt.Sprintf(`
 name: %s

diff --git a/ddtrace/mocktracer/mockspan_test.go b/ddtrace/mocktracer/mockspan_test.go
@@ -192,6 +192,14 @@ func TestSpanFinishTwice(t *testing.T) {
 	assert.Equal(len(s.tracer.finishedSpans), 1)
 }
 
+func TestSpanString(t *testing.T) {
+	s := basicSpan("http.request")
+	s.Finish(tracer.WithError(errors.New("some error")))
+
+	assert := assert.New(t)
+	assert.NotEmpty(s.String())
+}
+
 func TestSpanWithID(t *testing.T) {
 	spanID := uint64(123456789)
 	span := newMockTracer().StartSpan("", tracer.WithSpanID(spanID))