Skip to content

Commit

Permalink
Revert "Merge branch 'feature-fast-delta-profiling' into release-v1.4…
Browse files Browse the repository at this point in the history
…3.x"

This reverts commit efbfa56, reversing
changes made to 7930c6d.
  • Loading branch information
pmbauer committed Oct 7, 2022
1 parent cdda463 commit 7c6a652
Show file tree
Hide file tree
Showing 30 changed files with 71 additions and 2,173 deletions.
9 changes: 0 additions & 9 deletions contrib/database/sql/sql.go
Original file line number Diff line number Diff line change
Expand Up @@ -224,14 +224,5 @@ func Open(driverName, dataSourceName string, opts ...Option) (*sql.DB, error) {
return nil, errNotRegistered
}
d, _ := registeredDrivers.driver(driverName)
if driverCtx, ok := d.(driver.DriverContext); ok {
connector, err := driverCtx.OpenConnector(dataSourceName)
if err != nil {
return nil, err
}
// since we're not using the dsnConnector, we need to register the dsn manually in the config
opts = append(opts, WithDSN(dataSourceName))
return OpenDB(connector, opts...), nil
}
return OpenDB(&dsnConnector{dsn: dataSourceName, driver: d}, opts...), nil
}
7 changes: 3 additions & 4 deletions ddtrace/tracer/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -661,10 +661,9 @@ func WithRuntimeMetrics() StartOption {
// WithDogstatsdAddress specifies the address to connect to for sending metrics to the Datadog
// Agent. It should be a "host:port" string, or the path to a unix domain socket.If not set, it
// attempts to determine the address of the statsd service according to the following rules:
// 1. Look for /var/run/datadog/dsd.socket and use it if present. IF NOT, continue to #2.
// 2. The host is determined by DD_AGENT_HOST, and defaults to "localhost"
// 3. The port is retrieved from the agent. If not present, it is determined by DD_DOGSTATSD_PORT, and defaults to 8125
//
// 1. Look for /var/run/datadog/dsd.socket and use it if present. IF NOT, continue to #2.
// 2. The host is determined by DD_AGENT_HOST, and defaults to "localhost"
// 3. The port is retrieved from the agent. If not present, it is determined by DD_DOGSTATSD_PORT, and defaults to 8125
// This option is in effect when WithRuntimeMetrics is enabled.
func WithDogstatsdAddress(addr string) StartOption {
return func(cfg *config) {
Expand Down
10 changes: 1 addition & 9 deletions ddtrace/tracer/tracer.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/internal"
"gopkg.in/DataDog/dd-trace-go.v1/internal/appsec"
"gopkg.in/DataDog/dd-trace-go.v1/internal/log"
"gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig"
"gopkg.in/DataDog/dd-trace-go.v1/internal/traceprof"

"github.com/DataDog/datadog-agent/pkg/obfuscate"
Expand Down Expand Up @@ -127,14 +126,6 @@ func Start(opts ...StartOption) {
if t.config.logStartup {
logStartup(t)
}
// Start AppSec with remote configuration
cfg := remoteconfig.DefaultClientConfig()
cfg.AgentAddr = t.config.agentAddr
cfg.AppVersion = t.config.version
cfg.Env = t.config.env
cfg.HTTP = t.config.httpClient
cfg.ServiceName = t.config.serviceName
appsec.Start(appsec.WithRCConfig(cfg))
}

// Stop stops the started tracer. Subsequent calls are valid but become no-op.
Expand Down Expand Up @@ -260,6 +251,7 @@ func newTracer(opts ...StartOption) *tracer {
t.reportHealthMetrics(statsInterval)
}()
t.stats.Start()
appsec.Start()
return t
}

Expand Down
23 changes: 10 additions & 13 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ require (
cloud.google.com/go/pubsub v1.4.0
github.com/99designs/gqlgen v0.16.0
github.com/DataDog/datadog-agent/pkg/obfuscate v0.0.0-20211129110424-6491aa3bf583
github.com/DataDog/datadog-agent/pkg/remoteconfig/state v0.40.0-rc.2.0.20220929172920-a43645df5cf2
github.com/DataDog/datadog-go/v5 v5.0.2
github.com/DataDog/gostackparse v0.5.0
github.com/DataDog/sketches-go v1.2.1
Expand Down Expand Up @@ -52,16 +51,13 @@ require (
github.com/lib/pq v1.10.2
github.com/mattn/go-sqlite3 v1.14.12
github.com/miekg/dns v1.1.25
github.com/mitchellh/mapstructure v1.4.2 // indirect
github.com/opentracing/opentracing-go v1.2.0
github.com/pierrec/lz4 v2.5.2+incompatible // indirect
github.com/segmentio/kafka-go v0.4.29
github.com/sirupsen/logrus v1.7.0
github.com/stretchr/testify v1.8.0
github.com/syndtr/goleveldb v1.0.1-0.20220721030215-126854af5e6d
github.com/stretchr/testify v1.7.1
github.com/syndtr/goleveldb v1.0.0
github.com/tidwall/buntdb v1.2.0
github.com/tidwall/grect v0.1.4 // indirect
github.com/tinylib/msgp v1.1.6
github.com/tinylib/msgp v1.1.2
github.com/twitchtv/twirp v8.1.1+incompatible
github.com/urfave/negroni v1.0.0
github.com/valyala/fasthttp v1.34.0 // indirect
Expand All @@ -74,7 +70,7 @@ require (
golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f
golang.org/x/time v0.0.0-20211116232009-f0f3c7e86c11
golang.org/x/xerrors v0.0.0-20220517211312-f3a8303e98df
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
google.golang.org/api v0.29.0
google.golang.org/grpc v1.32.0
google.golang.org/protobuf v1.28.0
Expand Down Expand Up @@ -164,21 +160,22 @@ require (
github.com/mattn/go-colorable v0.1.11 // indirect
github.com/mattn/go-isatty v0.0.14 // indirect
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/mitchellh/mapstructure v1.4.2 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.1 // indirect
github.com/onsi/ginkgo v1.16.4 // indirect
github.com/onsi/gomega v1.16.0 // indirect
github.com/philhofer/fwd v1.1.1 // indirect
github.com/pierrec/lz4 v2.5.2+incompatible // indirect
github.com/pierrec/lz4/v4 v4.1.14 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/rcrowley/go-metrics v0.0.0-20181016184325-3113b8401b8a // indirect
github.com/richardartoul/molecule v1.0.0
github.com/ryanuber/go-glob v1.0.0 // indirect
github.com/secure-systems-lab/go-securesystemslib v0.4.0 // indirect
github.com/spaolacci/murmur3 v1.1.0
github.com/spf13/pflag v1.0.5 // indirect
github.com/theupdateframework/go-tuf v0.3.0 // indirect
github.com/tidwall/btree v0.3.0 // indirect
github.com/tidwall/btree v1.1.0 // indirect
github.com/tidwall/gjson v1.12.1 // indirect
github.com/tidwall/grect v0.1.4 // indirect
github.com/tidwall/match v1.1.1 // indirect
github.com/tidwall/pretty v1.2.0 // indirect
github.com/tidwall/rtred v0.1.2 // indirect
Expand Down
Loading

0 comments on commit 7c6a652

Please sign in to comment.