tracer: move reflect nil error check to WithError to never set a bad …

…nil value
DataDog · Jun 12, 2023 · ca97dad · ca97dad
1 parent 2a0f38c
commit ca97dad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/ddtrace/tracer/option.go b/ddtrace/tracer/option.go
@@ -15,6 +15,7 @@ import (
 	"net/url"
 	"os"
 	"path/filepath"
+	"reflect"
 	"runtime"
 	"strconv"
 	"strings"
@@ -892,6 +893,9 @@ func FinishTime(t time.Time) FinishOption {
 // err to set tags such as the error message, error type and stack trace. It has
 // no effect if the error is nil.
 func WithError(err error) FinishOption {
+	if err == nil || reflect.ValueOf(err).IsNil() {
+		return func(_ *ddtrace.FinishConfig) {}
+	}
 	return func(cfg *ddtrace.FinishConfig) {
 		cfg.Error = err
 	}

diff --git a/ddtrace/tracer/span.go b/ddtrace/tracer/span.go
@@ -424,7 +424,7 @@ func (s *span) Finish(opts ...ddtrace.FinishOption) {
 		if !cfg.FinishTime.IsZero() {
 			t = cfg.FinishTime.UnixNano()
 		}
-		if cfg.Error != nil && !reflect.ValueOf(cfg.Error).IsNil() {
+		if cfg.Error != nil {
 			s.Lock()
 			s.setTagError(cfg.Error, errorConfig{
 				noDebugStack: cfg.NoDebugStack,