Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: contrib/google.golang.org/grpc: add WithSpanOptions #1125

Closed
gbbr opened this issue Jan 13, 2022 · 0 comments · Fixed by #1159
Closed

proposal: contrib/google.golang.org/grpc: add WithSpanOptions #1125

gbbr opened this issue Jan 13, 2022 · 0 comments · Fixed by #1159
Labels
ack apm:ecosystem contrib/* related feature requests or bugs proposal/accepted Accepted proposals proposal more in depth change that requires full team approval

Comments

@gbbr
Copy link
Contributor

gbbr commented Jan 13, 2022 •
edited

The proposal is to add support for a WithSpanOptions option to interceptors, so that users can set additional tags or options on started spans, without using additional interceptors to wrap. An example of the same option can be seen in the net/http integration: https://pkg.go.dev/gopkg.in/DataDog/dd-trace-go.v1/contrib/net/http#WithSpanOptions

The request is coming from Datadog internally.
@gbbr gbbr added proposal more in depth change that requires full team approval proposal/accepted Accepted proposals labels Jan 13, 2022
@knusbaum knusbaum added the ack label Jan 14, 2022
@mackjmr mackjmr mentioned this issue Feb 4, 2022
Merged
@katiehockman katiehockman added the apm:ecosystem contrib/* related feature requests or bugs label Jan 11, 2023
@balogal balogal mentioned this issue Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ack apm:ecosystem contrib/* related feature requests or bugs proposal/accepted Accepted proposals proposal more in depth change that requires full team approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

contrib/google.golang.org/{grpc, grpc.v12}: add support for WithSpanOptions DataDog/dd-trace-go
3 participants
@knusbaum @gbbr @katiehockman