-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/google.golang.org/{grpc, grpc.v12}: add support for WithSpanOptions #1159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. IIRC @talig was looking for something like this in order to add custom tags to all spans.
Anyway, just a quick comment from me. I'll leave it to @DataDog/tracing-go to review the full PR.
34441f7
to
91621eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I will also ask @ajgajg1134 to look through real quick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looks good to me!
This PR add's support for WithSpanOptions for both contrib/google.golang.org/grpc and contrib/google.golang.org/grpc.v12
Fixes: #1125